Is this trap effective?

From the best plumber Vancouver WA 98682

Is this trap effective?

Had my handyman make my washing machine water shutoff more accessible and also fix my lack of P-trap (had sewer smell issues). Will the trap he set up do the job? It looks more like an S-trap but maybe given where the roof vent is it’s still okay? Here are the pics.

Before:

https://i.redd.it/tkyvmi4hoem31.jpg

After:

https://i.redd.it/j54yaa6foem31.jpg

Advice/insight very much appreciated. Thanks!

submitted by /u/eugkis5
[link] [comments]

From the top plumbing contractor Vancouver WA 98682